Sourcing pytest-check-hook Using pytestCheckPhase Running phase: unpackPhase unpacking source archive /nix/store/kgh759qcrpwj7rs2wvp66c1k1wcizf7b-source source root is source Running phase: patchPhase Running phase: updateAutotoolsGnuConfigScriptsPhase Running phase: configurePhase no configure script, doing nothing Running phase: buildPhase Running: $ pre-commit run --all-files actionlint...............................................................Passed - hook id: actionlint - duration: 0.05s ansible-lint.............................................................Passed - hook id: ansible-lint - duration: 19.88s [WARNING]: Deprecation warnings can be disabled by setting `deprecation_warnings=False` in ansible.cfg. [DEPRECATION WARNING]: Importing 'to_bytes' from 'ansible.module_utils._text' is deprecated. This feature will be removed from ansible-core version 2.24. Use ansible.module_utils.common.text.converters instead. WARNING Ignored exception from ArgsRule.matchtasks while processing ansible/tasks/setup-system.yml (tasks): [Errno 36] File name too long: '{"ANSIBLE_MODULE_ARGS": {"name": "ubuntu", "uid": "{{ uids.ubuntu }}", "group": "ubuntu", "groups": ["adm", "audio", "cdrom", "dialout", "dip", "floppy", "lxd", "netdev", "plugdev", "sudo", "video"], "comment": "Ubuntu", "create_home": true, "password_lock": true, "shell": "/bin/bash", "state": "present"}}' WARNING Ignored exception from ArgsRule.matchtasks while processing ansible/tasks/stage2-setup-postgres.yml (tasks): [Errno 36] File name too long: '{"ANSIBLE_MODULE_ARGS": {"group": "postgres", "mode": "{{ file_item[\'mode\'] | default(\'0755\', true) }}", "owner": "{{ file_item[\'owner\'] | default(\'postgres\', true) }}", "path": "{{ file_item[\'path\'] }}", "state": "{{ file_item[\'state\'] | default(\'directory\', true) }}"}}' [DEPRECATION WARNING]: Importing 'to_native' from 'ansible.module_utils._text' is deprecated. This feature will be removed from ansible-core version 2.24. Use ansible.module_utils.common.text.converters instead. WARNING /nix/store/sv655rl926y5060hd77cflbfil7lb7lv-python3.13-ansible-core-2.20.0/lib/python3.13/site-packages/ansible/utils/display.py:718 AnsibleWarning Deprecation warnings can be disabled by setting `deprecation_warnings=False` in ansible.cfg. WARNING /nix/store/sv655rl926y5060hd77cflbfil7lb7lv-python3.13-ansible-core-2.20.0/lib/python3.13/site-packages/ansible/utils/display.py:718 AnsibleWarning Deprecation warnings can be disabled by setting `deprecation_warnings=False` in ansible.cfg. WARNING /nix/store/sv655rl926y5060hd77cflbfil7lb7lv-python3.13-ansible-core-2.20.0/lib/python3.13/site-packages/ansible/utils/display.py:718 AnsibleWarning Deprecation warnings can be disabled by setting `deprecation_warnings=False` in ansible.cfg. WARNING /nix/store/sv655rl926y5060hd77cflbfil7lb7lv-python3.13-ansible-core-2.20.0/lib/python3.13/site-packages/ansible/utils/display.py:718 AnsibleWarning Deprecation warnings can be disabled by setting `deprecation_warnings=False` in ansible.cfg. WARNING Found incompatible custom yamllint configuration (.yamllint), please either remove the file or edit it to comply with: - comments.min-spaces-from-content must be 1. Read https://ansible.readthedocs.io/projects/lint/rules/yaml/ for more details regarding why we have these requirements. Fix mode will not be available. WARNING Listing 367 violation(s) marked as ignored, likely already known yaml[empty-lines]: Too many blank lines (1 > 0) (warning) # ignored ansible/files/envoy_config/cds.yaml:86 yaml[empty-lines]: Too many blank lines (1 > 0) (warning) # ignored ansible/files/envoy_config/envoy.yaml:23 yaml[empty-lines]: Too many blank lines (1 > 0) (warning) # ignored ansible/files/envoy_config/lds.supabase.yaml:406 yaml[empty-lines]: Too many blank lines (1 > 0) (warning) # ignored ansible/files/envoy_config/lds.yaml:450 name[play]: All plays should be named. (warning) # ignored ansible/playbook.yml:1:3 fqcn[action-core]: Use FQCN for builtin module actions (import_tasks). (warning) # ignored ansible/playbook.yml:23:7 Use `ansible.builtin.import_tasks` or `ansible.legacy.import_tasks` instead. name[missing]: All tasks should be named. (warning) # ignored ansible/playbook.yml:23 Task/Handler: import_tasks tasks/setup-system.yml fqcn[action-core]: Use FQCN for builtin module actions (import_tasks). (warning) # ignored ansible/playbook.yml:26:7 Use `ansible.builtin.import_tasks` or `ansible.legacy.import_tasks` instead. fqcn[action-core]: Use FQCN for builtin module actions (import_tasks). (warning) # ignored ansible/playbook.yml:29:7 Use `ansible.builtin.import_tasks` or `ansible.legacy.import_tasks` instead. fqcn[action-core]: Use FQCN for builtin module actions (import_tasks). (warning) # ignored ansible/playbook.yml:32:7 Use `ansible.builtin.import_tasks` or `ansible.legacy.import_tasks` instead. fqcn[action-core]: Use FQCN for builtin module actions (import_tasks). (warning) # ignored ansible/playbook.yml:36:7 Use `ansible.builtin.import_tasks` or `ansible.legacy.import_tasks` instead. fqcn[action-core]: Use FQCN for builtin module actions (import_tasks). (warning) # ignored ansible/playbook.yml:39:7 Use `ansible.builtin.import_tasks` or `ansible.legacy.import_tasks` instead. fqcn[action-core]: Use FQCN for builtin module actions (import_tasks). (warning) # ignored ansible/playbook.yml:45:7 Use `ansible.builtin.import_tasks` or `ansible.legacy.import_tasks` instead. fqcn[action-core]: Use FQCN for builtin module actions (import_tasks). (warning) # ignored ansible/playbook.yml:48:7 Use `ansible.builtin.import_tasks` or `ansible.legacy.import_tasks` instead. fqcn[action-core]: Use FQCN for builtin module actions (import_tasks). (warning) # ignored ansible/playbook.yml:59:7 Use `ansible.builtin.import_tasks` or `ansible.legacy.import_tasks` instead. fqcn[action-core]: Use FQCN for builtin module actions (import_tasks). (warning) # ignored ansible/playbook.yml:66:7 Use `ansible.builtin.import_tasks` or `ansible.legacy.import_tasks` instead. fqcn[action-core]: Use FQCN for builtin module actions (import_tasks). (warning) # ignored ansible/playbook.yml:73:7 Use `ansible.builtin.import_tasks` or `ansible.legacy.import_tasks` instead. fqcn[action-core]: Use FQCN for builtin module actions (import_tasks). (warning) # ignored ansible/playbook.yml:79:7 Use `ansible.builtin.import_tasks` or `ansible.legacy.import_tasks` instead. fqcn[action-core]: Use FQCN for builtin module actions (import_tasks). (warning) # ignored ansible/playbook.yml:85:7 Use `ansible.builtin.import_tasks` or `ansible.legacy.import_tasks` instead. fqcn[action-core]: Use FQCN for builtin module actions (import_tasks). (warning) # ignored ansible/playbook.yml:91:7 Use `ansible.builtin.import_tasks` or `ansible.legacy.import_tasks` instead. risky-file-permissions: File permissions unset or incorrect. (warning) # ignored ansible/playbook.yml:95 Task/Handler: Adjust APT update intervals fqcn[action-core]: Use FQCN for builtin module actions (copy). (warning) # ignored ansible/playbook.yml:97:7 Use `ansible.builtin.copy` or `ansible.legacy.copy` instead. risky-file-permissions: File permissions unset or incorrect. (warning) # ignored ansible/playbook.yml:101 Task/Handler: Transfer init SQL files fqcn[action-core]: Use FQCN for builtin module actions (copy). (warning) # ignored ansible/playbook.yml:103:7 Use `ansible.builtin.copy` or `ansible.legacy.copy` instead. no-changed-when: Commands should not change things if nothing needs doing. (warning) # ignored ansible/playbook.yml:108 Task/Handler: Create postgres role fqcn[action-core]: Use FQCN for builtin module actions (shell). (warning) # ignored ansible/playbook.yml:112:7 Use `ansible.builtin.shell` or `ansible.legacy.shell` instead. command-instead-of-shell: Use shell only when shell functionality is required. (warning) # ignored ansible/playbook.yml:115 Task/Handler: Execute init SQL files no-changed-when: Commands should not change things if nothing needs doing. (warning) # ignored ansible/playbook.yml:115 Task/Handler: Execute init SQL files fqcn[action-core]: Use FQCN for builtin module actions (shell). (warning) # ignored ansible/playbook.yml:119:7 Use `ansible.builtin.shell` or `ansible.legacy.shell` instead. fqcn[action-core]: Use FQCN for builtin module actions (file). (warning) # ignored ansible/playbook.yml:125:7 Use `ansible.builtin.file` or `ansible.legacy.file` instead. fqcn[action-core]: Use FQCN for builtin module actions (import_tasks). (warning) # ignored ansible/playbook.yml:132:7 Use `ansible.builtin.import_tasks` or `ansible.legacy.import_tasks` instead. fqcn[action-core]: Use FQCN for builtin module actions (import_tasks). (warning) # ignored ansible/playbook.yml:138:7 Use `ansible.builtin.import_tasks` or `ansible.legacy.import_tasks` instead. fqcn[action-core]: Use FQCN for builtin module actions (import_tasks). (warning) # ignored ansible/playbook.yml:144:7 Use `ansible.builtin.import_tasks` or `ansible.legacy.import_tasks` instead. fqcn[action-core]: Use FQCN for builtin module actions (apt). (warning) # ignored ansible/playbook.yml:149:7 Use `ansible.builtin.apt` or `ansible.legacy.apt` instead. fqcn[action-core]: Use FQCN for builtin module actions (import_tasks). (warning) # ignored ansible/playbook.yml:155:7 Use `ansible.builtin.import_tasks` or `ansible.legacy.import_tasks` instead. fqcn[action-core]: Use FQCN for builtin module actions (import_tasks). (warning) # ignored ansible/playbook.yml:161:7 Use `ansible.builtin.import_tasks` or `ansible.legacy.import_tasks` instead. no-changed-when: Commands should not change things if nothing needs doing. (warning) # ignored ansible/playbook.yml:165 Task/Handler: Purge snapd fqcn[action-core]: Use FQCN for builtin module actions (shell). (warning) # ignored ansible/playbook.yml:168:7 Use `ansible.builtin.shell` or `ansible.legacy.shell` instead. command-instead-of-module: systemctl used in place of systemd module (warning) # ignored ansible/playbook.yml:171 Task/Handler: Run permission checks no-changed-when: Commands should not change things if nothing needs doing. (warning) # ignored ansible/playbook.yml:171 Task/Handler: Run permission checks fqcn[action-core]: Use FQCN for builtin module actions (shell). (warning) # ignored ansible/playbook.yml:174:7 Use `ansible.builtin.shell` or `ansible.legacy.shell` instead. command-instead-of-module: systemctl used in place of systemd module (warning) # ignored ansible/playbook.yml:179 Task/Handler: Run fail2ban configuration checks no-changed-when: Commands should not change things if nothing needs doing. (warning) # ignored ansible/playbook.yml:179 Task/Handler: Run fail2ban configuration checks fqcn[action-core]: Use FQCN for builtin module actions (shell). (warning) # ignored ansible/playbook.yml:182:7 Use `ansible.builtin.shell` or `ansible.legacy.shell` instead. no-changed-when: Commands should not change things if nothing needs doing. (warning) # ignored ansible/playbook.yml:187 Task/Handler: Run supascan baseline validation fqcn[action-core]: Use FQCN for builtin module actions (shell). (warning) # ignored ansible/playbook.yml:189:7 Use `ansible.builtin.shell` or `ansible.legacy.shell` instead. fqcn[action-core]: Use FQCN for builtin module actions (import_tasks). (warning) # ignored ansible/playbook.yml:197:7 Use `ansible.builtin.import_tasks` or `ansible.legacy.import_tasks` instead. fqcn[action-core]: Use FQCN for builtin module actions (import_tasks). (warning) # ignored ansible/playbook.yml:202:7 Use `ansible.builtin.import_tasks` or `ansible.legacy.import_tasks` instead. fqcn[action-core]: Use FQCN for builtin module actions (import_tasks). (warning) # ignored ansible/playbook.yml:206:7 Use `ansible.builtin.import_tasks` or `ansible.legacy.import_tasks` instead. risky-file-permissions: File permissions unset or incorrect. (warning) # ignored ansible/tasks/finalize-ami.yml:1 Task/Handler: PG logging conf name[casing]: All names should start with an uppercase letter. (warning) # ignored ansible/tasks/finalize-ami.yml:7:9 Task/Handler: auto_explain, pg_cron, and pg_net confs risky-file-permissions: File permissions unset or incorrect. (warning) # ignored ansible/tasks/finalize-ami.yml:7 Task/Handler: auto_explain, pg_cron, and pg_net confs risky-file-permissions: File permissions unset or incorrect. (warning) # ignored ansible/tasks/finalize-ami.yml:74 Task/Handler: Disable cron access fqcn[action-core]: Use FQCN for builtin module actions (copy). (warning) # ignored ansible/tasks/finalize-ami.yml:75:3 Use `ansible.builtin.copy` or `ansible.legacy.copy` instead. name[casing]: All names should start with an uppercase letter. (warning) # ignored ansible/tasks/finalize-ami.yml:109:9 Task/Handler: import pgsodium_getkey script name[casing]: All names should start with an uppercase letter. (warning) # ignored ansible/tasks/fix-ipv6-ndisc.yml:2:9 Task/Handler: fix Network - systemd timer and service file name[casing]: All names should start with an uppercase letter. (warning) # ignored ansible/tasks/fix-ipv6-ndisc.yml:15:9 Task/Handler: fix Network - detect script name[casing]: All names should start with an uppercase letter. (warning) # ignored ansible/tasks/fix-ipv6-ndisc.yml:23:9 Task/Handler: fix Network - reload systemd name[casing]: All names should start with an uppercase letter. (warning) # ignored ansible/tasks/fix-ipv6-ndisc.yml:27:9 Task/Handler: fix Network - ensure systemd timer is installed but disabled name[casing]: All names should start with an uppercase letter. (warning) # ignored ansible/tasks/internal/admin-api.yml:1:9 Task/Handler: adminapi - system group name[casing]: All names should start with an uppercase letter. (warning) # ignored ansible/tasks/internal/admin-api.yml:7:9 Task/Handler: adminapi - system user fqcn[action-core]: Use FQCN for builtin module actions (copy). (warning) # ignored ansible/tasks/internal/admin-api.yml:15:3 Use `ansible.builtin.copy` or `ansible.legacy.copy` instead. name[casing]: All names should start with an uppercase letter. (warning) # ignored ansible/tasks/internal/admin-api.yml:27:9 Task/Handler: give adminapi user permissions fqcn[action-core]: Use FQCN for builtin module actions (copy). (warning) # ignored ansible/tasks/internal/admin-api.yml:28:3 Use `ansible.builtin.copy` or `ansible.legacy.copy` instead. name[casing]: All names should start with an uppercase letter. (warning) # ignored ansible/tasks/internal/admin-api.yml:34:9 Task/Handler: perms for adminapi no-changed-when: Commands should not change things if nothing needs doing. (warning) # ignored ansible/tasks/internal/admin-api.yml:34 Task/Handler: perms for adminapi fqcn[action-core]: Use FQCN for builtin module actions (shell). (warning) # ignored ansible/tasks/internal/admin-api.yml:35:3 Use `ansible.builtin.shell` or `ansible.legacy.shell` instead. risky-file-permissions: File permissions unset or incorrect. (warning) # ignored ansible/tasks/internal/admin-api.yml:38 Task/Handler: Download adminapi archive fqcn[action-core]: Use FQCN for builtin module actions (get_url). (warning) # ignored ansible/tasks/internal/admin-api.yml:39:3 Use `ansible.builtin.get_url` or `ansible.legacy.get_url` instead. name[casing]: All names should start with an uppercase letter. (warning) # ignored ansible/tasks/internal/admin-api.yml:45:9 Task/Handler: adminapi - unpack archive in /opt fqcn[action-core]: Use FQCN for builtin module actions (unarchive). (warning) # ignored ansible/tasks/internal/admin-api.yml:46:3 Use `ansible.builtin.unarchive` or `ansible.legacy.unarchive` instead. name[casing]: All names should start with an uppercase letter. (warning) # ignored ansible/tasks/internal/admin-api.yml:52:9 Task/Handler: adminapi - config dir risky-file-permissions: File permissions unset or incorrect. (warning) # ignored ansible/tasks/internal/admin-api.yml:52 Task/Handler: adminapi - config dir fqcn[action-core]: Use FQCN for builtin module actions (file). (warning) # ignored ansible/tasks/internal/admin-api.yml:53:3 Use `ansible.builtin.file` or `ansible.legacy.file` instead. name[casing]: All names should start with an uppercase letter. (warning) # ignored ansible/tasks/internal/admin-api.yml:58:9 Task/Handler: adminapi - pg_upgrade scripts dir risky-file-permissions: File permissions unset or incorrect. (warning) # ignored ansible/tasks/internal/admin-api.yml:58 Task/Handler: adminapi - pg_upgrade scripts dir fqcn[action-core]: Use FQCN for builtin module actions (file). (warning) # ignored ansible/tasks/internal/admin-api.yml:59:3 Use `ansible.builtin.file` or `ansible.legacy.file` instead. fqcn[action-core]: Use FQCN for builtin module actions (copy). (warning) # ignored ansible/tasks/internal/admin-api.yml:65:3 Use `ansible.builtin.copy` or `ansible.legacy.copy` instead. name[casing]: All names should start with an uppercase letter. (warning) # ignored ansible/tasks/internal/admin-api.yml:79:9 Task/Handler: adminapi - create service file risky-file-permissions: File permissions unset or incorrect. (warning) # ignored ansible/tasks/internal/admin-api.yml:79 Task/Handler: adminapi - create service file fqcn[action-core]: Use FQCN for builtin module actions (template). (warning) # ignored ansible/tasks/internal/admin-api.yml:80:3 Use `ansible.builtin.template` or `ansible.legacy.template` instead. name[casing]: All names should start with an uppercase letter. (warning) # ignored ansible/tasks/internal/admin-api.yml:84:9 Task/Handler: adminapi - create service file for commence backup process risky-file-permissions: File permissions unset or incorrect. (warning) # ignored ansible/tasks/internal/admin-api.yml:84 Task/Handler: adminapi - create service file for commence backup process fqcn[action-core]: Use FQCN for builtin module actions (template). (warning) # ignored ansible/tasks/internal/admin-api.yml:85:3 Use `ansible.builtin.template` or `ansible.legacy.template` instead. name[casing]: All names should start with an uppercase letter. (warning) # ignored ansible/tasks/internal/admin-api.yml:89:9 Task/Handler: adminapi - create service file for commence restore process risky-file-permissions: File permissions unset or incorrect. (warning) # ignored ansible/tasks/internal/admin-api.yml:89 Task/Handler: adminapi - create service file for commence restore process fqcn[action-core]: Use FQCN for builtin module actions (template). (warning) # ignored ansible/tasks/internal/admin-api.yml:90:3 Use `ansible.builtin.template` or `ansible.legacy.template` instead. fqcn[action]: Use FQCN for module actions, such `community.general.ufw`. (warning) # ignored ansible/tasks/internal/admin-api.yml:95:3 Action `ufw` is not FQCN. name[casing]: All names should start with an uppercase letter. (warning) # ignored ansible/tasks/internal/admin-api.yml:99:9 Task/Handler: adminapi - reload systemd fqcn[action-core]: Use FQCN for builtin module actions (systemd). (warning) # ignored ansible/tasks/internal/admin-api.yml:100:3 Use `ansible.builtin.systemd` or `ansible.legacy.systemd` instead. name[casing]: All names should start with an uppercase letter. (warning) # ignored ansible/tasks/internal/admin-api.yml:103:9 Task/Handler: adminapi - grant extra priviliges to user no-changed-when: Commands should not change things if nothing needs doing. (warning) # ignored ansible/tasks/internal/admin-api.yml:103 Task/Handler: adminapi - grant extra priviliges to user fqcn[action-core]: Use FQCN for builtin module actions (shell). (warning) # ignored ansible/tasks/internal/admin-api.yml:104:3 Use `ansible.builtin.shell` or `ansible.legacy.shell` instead. risky-file-permissions: File permissions unset or incorrect. (warning) # ignored ansible/tasks/internal/admin-mgr.yml:1 Task/Handler: Download admin-mgr archive fqcn[action-core]: Use FQCN for builtin module actions (get_url). (warning) # ignored ansible/tasks/internal/admin-mgr.yml:2:3 Use `ansible.builtin.get_url` or `ansible.legacy.get_url` instead. name[casing]: All names should start with an uppercase letter. (warning) # ignored ansible/tasks/internal/admin-mgr.yml:12:9 Task/Handler: admin-mgr - unpack archive in /usr/bin/ fqcn[action-core]: Use FQCN for builtin module actions (unarchive). (warning) # ignored ansible/tasks/internal/admin-mgr.yml:13:3 Use `ansible.builtin.unarchive` or `ansible.legacy.unarchive` instead. risky-file-permissions: File permissions unset or incorrect. (warning) # ignored ansible/tasks/internal/collect-pg-binaries.yml:1 Task/Handler: Collect Postgres binaries - create collection directory fqcn[action-core]: Use FQCN for builtin module actions (file). (warning) # ignored ansible/tasks/internal/collect-pg-binaries.yml:2:3 Use `ansible.builtin.file` or `ansible.legacy.file` instead. risky-file-permissions: File permissions unset or incorrect. (warning) # ignored ansible/tasks/internal/collect-pg-binaries.yml:6 Task/Handler: Collect Postgres binaries - collect binaries and libraries fqcn[action-core]: Use FQCN for builtin module actions (copy). (warning) # ignored ansible/tasks/internal/collect-pg-binaries.yml:7:3 Use `ansible.builtin.copy` or `ansible.legacy.copy` instead. risky-file-permissions: File permissions unset or incorrect. (warning) # ignored ansible/tasks/internal/collect-pg-binaries.yml:15 Task/Handler: Collect Postgres libraries - collect libraries which are in /usr/lib/postgresql/lib/ fqcn[action-core]: Use FQCN for builtin module actions (copy). (warning) # ignored ansible/tasks/internal/collect-pg-binaries.yml:16:3 Use `ansible.builtin.copy` or `ansible.legacy.copy` instead. risky-file-permissions: File permissions unset or incorrect. (warning) # ignored ansible/tasks/internal/collect-pg-binaries.yml:21 Task/Handler: Collect Postgres libraries - collect libraries which are in /var/lib/postgresql/extension/ fqcn[action-core]: Use FQCN for builtin module actions (copy). (warning) # ignored ansible/tasks/internal/collect-pg-binaries.yml:22:3 Use `ansible.builtin.copy` or `ansible.legacy.copy` instead. risky-file-permissions: File permissions unset or incorrect. (warning) # ignored ansible/tasks/internal/collect-pg-binaries.yml:27 Task/Handler: Collect Postgres libraries - collect latest libpq fqcn[action-core]: Use FQCN for builtin module actions (copy). (warning) # ignored ansible/tasks/internal/collect-pg-binaries.yml:28:3 Use `ansible.builtin.copy` or `ansible.legacy.copy` instead. risky-file-permissions: File permissions unset or incorrect. (warning) # ignored ansible/tasks/internal/collect-pg-binaries.yml:33 Task/Handler: Collect Postgres binaries - collect shared files fqcn[action-core]: Use FQCN for builtin module actions (copy). (warning) # ignored ansible/tasks/internal/collect-pg-binaries.yml:34:3 Use `ansible.builtin.copy` or `ansible.legacy.copy` instead. risky-file-permissions: File permissions unset or incorrect. (warning) # ignored ansible/tasks/internal/collect-pg-binaries.yml:39 Task/Handler: Collect Postgres binaries - create tarfile fqcn[action]: Use FQCN for module actions, such `community.general.archive`. (warning) # ignored ansible/tasks/internal/collect-pg-binaries.yml:40:3 Action `archive` is not FQCN. fqcn[action-core]: Use FQCN for builtin module actions (fetch). (warning) # ignored ansible/tasks/internal/collect-pg-binaries.yml:46:3 Use `ansible.builtin.fetch` or `ansible.legacy.fetch` instead. risky-file-permissions: File permissions unset or incorrect. (warning) # ignored ansible/tasks/internal/install-aws-cli.yml:20 Task/Handler: AWS CLI - get no-changed-when: Commands should not change things if nothing needs doing. (warning) # ignored ansible/tasks/internal/install-aws-cli.yml:37 Task/Handler: AWS CLI - install name[casing]: All names should start with an uppercase letter. (warning) # ignored ansible/tasks/internal/install-aws-cli.yml:42:9 Task/Handler: install utilities to manage Amazon EC2 instance storage no-changed-when: Commands should not change things if nothing needs doing. (warning) # ignored ansible/tasks/internal/install-aws-cli.yml:48 Task/Handler: AWS CLI - configure ipv6 support for s3 fqcn[action-core]: Use FQCN for builtin module actions (file). (warning) # ignored ansible/tasks/internal/install-salt.yml:4:7 Use `ansible.builtin.file` or `ansible.legacy.file` instead. name[casing]: All names should start with an uppercase letter. (warning) # ignored ansible/tasks/internal/install-salt.yml:9:13 Task/Handler: salt gpg key jinja[spacing]: Jinja2 spacing could be improved: {{salt_artifacts['url']}} -> {{ salt_artifacts['url'] }} (warning) # ignored ansible/tasks/internal/install-salt.yml:11:14 Jinja2 template rewrite recommendation: `{{ salt_artifacts['url'] }}`. jinja[spacing]: Jinja2 spacing could be improved: {{salt_artifacts['checksum']}} -> {{ salt_artifacts['checksum'] }} (warning) # ignored ansible/tasks/internal/install-salt.yml:12:19 Jinja2 template rewrite recommendation: `{{ salt_artifacts['checksum'] }}`. name[casing]: All names should start with an uppercase letter. (warning) # ignored ansible/tasks/internal/install-salt.yml:20:13 Task/Handler: salt apt repo fqcn[action-core]: Use FQCN for builtin module actions (apt). (warning) # ignored ansible/tasks/internal/install-salt.yml:27:3 Use `ansible.builtin.apt` or `ansible.legacy.apt` instead. name[casing]: All names should start with an uppercase letter. (warning) # ignored ansible/tasks/internal/optimizations.yml:1:9 Task/Handler: ensure services are stopped and disabled for first boot nix build fqcn[action-core]: Use FQCN for builtin module actions (systemd). (warning) # ignored ansible/tasks/internal/optimizations.yml:3:3 Use `ansible.builtin.systemd` or `ansible.legacy.systemd` instead. name[casing]: All names should start with an uppercase letter. (warning) # ignored ansible/tasks/internal/optimizations.yml:15:9 Task/Handler: disable man-db fqcn[action-core]: Use FQCN for builtin module actions (file). (warning) # ignored ansible/tasks/internal/optimizations.yml:18:3 Use `ansible.builtin.file` or `ansible.legacy.file` instead. name[casing]: All names should start with an uppercase letter. (warning) # ignored ansible/tasks/internal/pg_egress_collect.yml:1:9 Task/Handler: pg_egress_collect - install tcpdump and perl async lib fqcn[action-core]: Use FQCN for builtin module actions (apt). (warning) # ignored ansible/tasks/internal/pg_egress_collect.yml:2:3 Use `ansible.builtin.apt` or `ansible.legacy.apt` instead. name[casing]: All names should start with an uppercase letter. (warning) # ignored ansible/tasks/internal/pg_egress_collect.yml:7:9 Task/Handler: pg_egress_collect - create service file risky-file-permissions: File permissions unset or incorrect. (warning) # ignored ansible/tasks/internal/pg_egress_collect.yml:7 Task/Handler: pg_egress_collect - create service file fqcn[action-core]: Use FQCN for builtin module actions (template). (warning) # ignored ansible/tasks/internal/pg_egress_collect.yml:8:3 Use `ansible.builtin.template` or `ansible.legacy.template` instead. name[casing]: All names should start with an uppercase letter. (warning) # ignored ansible/tasks/internal/pg_egress_collect.yml:12:9 Task/Handler: pg_egress_collect - reload systemd fqcn[action-core]: Use FQCN for builtin module actions (systemd). (warning) # ignored ansible/tasks/internal/pg_egress_collect.yml:13:3 Use `ansible.builtin.systemd` or `ansible.legacy.systemd` instead. yaml[empty-lines]: Too many blank lines (1 > 0) (warning) # ignored ansible/tasks/internal/pg_egress_collect.yml:15 fqcn[action]: Use FQCN for module actions, such `community.general.ufw`. (warning) # ignored ansible/tasks/internal/postgres-exporter.yml:2:3 Action `ufw` is not FQCN. name[casing]: All names should start with an uppercase letter. (warning) # ignored ansible/tasks/internal/postgres-exporter.yml:6:9 Task/Handler: create directories - systemd unit fqcn[action-core]: Use FQCN for builtin module actions (file). (warning) # ignored ansible/tasks/internal/postgres-exporter.yml:7:3 Use `ansible.builtin.file` or `ansible.legacy.file` instead. name[casing]: All names should start with an uppercase letter. (warning) # ignored ansible/tasks/internal/postgres-exporter.yml:14:9 Task/Handler: create directories - service files fqcn[action-core]: Use FQCN for builtin module actions (file). (warning) # ignored ansible/tasks/internal/postgres-exporter.yml:15:3 Use `ansible.builtin.file` or `ansible.legacy.file` instead. name[casing]: All names should start with an uppercase letter. (warning) # ignored ansible/tasks/internal/postgres-exporter.yml:23:9 Task/Handler: download postgres exporter risky-file-permissions: File permissions unset or incorrect. (warning) # ignored ansible/tasks/internal/postgres-exporter.yml:23 Task/Handler: download postgres exporter fqcn[action-core]: Use FQCN for builtin module actions (get_url). (warning) # ignored ansible/tasks/internal/postgres-exporter.yml:24:3 Use `ansible.builtin.get_url` or `ansible.legacy.get_url` instead. name[casing]: All names should start with an uppercase letter. (warning) # ignored ansible/tasks/internal/postgres-exporter.yml:34:9 Task/Handler: expand postgres exporter fqcn[action-core]: Use FQCN for builtin module actions (unarchive). (warning) # ignored ansible/tasks/internal/postgres-exporter.yml:35:3 Use `ansible.builtin.unarchive` or `ansible.legacy.unarchive` instead. name[casing]: All names should start with an uppercase letter. (warning) # ignored ansible/tasks/internal/postgres-exporter.yml:42:9 Task/Handler: exporter create a service risky-file-permissions: File permissions unset or incorrect. (warning) # ignored ansible/tasks/internal/postgres-exporter.yml:42 Task/Handler: exporter create a service fqcn[action-core]: Use FQCN for builtin module actions (template). (warning) # ignored ansible/tasks/internal/postgres-exporter.yml:43:3 Use `ansible.builtin.template` or `ansible.legacy.template` instead. name[casing]: All names should start with an uppercase letter. (warning) # ignored ansible/tasks/internal/postgres-exporter.yml:47:9 Task/Handler: exporter ensure service is present fqcn[action-core]: Use FQCN for builtin module actions (systemd). (warning) # ignored ansible/tasks/internal/postgres-exporter.yml:48:3 Use `ansible.builtin.systemd` or `ansible.legacy.systemd` instead. name[casing]: All names should start with an uppercase letter. (warning) # ignored ansible/tasks/internal/postgresql-prestart.yml:1:9 Task/Handler: postgres_prestart - create service file fqcn[action-core]: Use FQCN for builtin module actions (template). (warning) # ignored ansible/tasks/internal/postgresql-prestart.yml:2:3 Use `ansible.builtin.template` or `ansible.legacy.template` instead. name[casing]: All names should start with an uppercase letter. (warning) # ignored ansible/tasks/internal/setup-ansible-pull.yml:1:9 Task/Handler: install ansible no-changed-when: Commands should not change things if nothing needs doing. (warning) # ignored ansible/tasks/internal/setup-ansible-pull.yml:1 Task/Handler: install ansible fqcn[action-core]: Use FQCN for builtin module actions (shell). (warning) # ignored ansible/tasks/internal/setup-ansible-pull.yml:2:3 Use `ansible.builtin.shell` or `ansible.legacy.shell` instead. name[casing]: All names should start with an uppercase letter. (warning) # ignored ansible/tasks/internal/setup-ansible-pull.yml:10:9 Task/Handler: ansible pull systemd units risky-file-permissions: File permissions unset or incorrect. (warning) # ignored ansible/tasks/internal/setup-ansible-pull.yml:10 Task/Handler: ansible pull systemd units fqcn[action-core]: Use FQCN for builtin module actions (copy). (warning) # ignored ansible/tasks/internal/setup-ansible-pull.yml:11:3 Use `ansible.builtin.copy` or `ansible.legacy.copy` instead. name[casing]: All names should start with an uppercase letter. (warning) # ignored ansible/tasks/internal/setup-ansible-pull.yml:18:9 Task/Handler: create facts dir risky-file-permissions: File permissions unset or incorrect. (warning) # ignored ansible/tasks/internal/setup-ansible-pull.yml:18 Task/Handler: create facts dir fqcn[action-core]: Use FQCN for builtin module actions (file). (warning) # ignored ansible/tasks/internal/setup-ansible-pull.yml:19:3 Use `ansible.builtin.file` or `ansible.legacy.file` instead. name[casing]: All names should start with an uppercase letter. (warning) # ignored ansible/tasks/internal/setup-ansible-pull.yml:23:9 Task/Handler: ansible facts risky-file-permissions: File permissions unset or incorrect. (warning) # ignored ansible/tasks/internal/setup-ansible-pull.yml:23 Task/Handler: ansible facts fqcn[action-core]: Use FQCN for builtin module actions (copy). (warning) # ignored ansible/tasks/internal/setup-ansible-pull.yml:24:3 Use `ansible.builtin.copy` or `ansible.legacy.copy` instead. name[casing]: All names should start with an uppercase letter. (warning) # ignored ansible/tasks/internal/setup-ansible-pull.yml:28:9 Task/Handler: reload systemd fqcn[action-core]: Use FQCN for builtin module actions (systemd). (warning) # ignored ansible/tasks/internal/setup-ansible-pull.yml:29:3 Use `ansible.builtin.systemd` or `ansible.legacy.systemd` instead. name[casing]: All names should start with an uppercase letter. (warning) # ignored ansible/tasks/internal/setup-nftables.yml:1:9 Task/Handler: nftables overrides risky-file-permissions: File permissions unset or incorrect. (warning) # ignored ansible/tasks/internal/setup-nftables.yml:1 Task/Handler: nftables overrides fqcn[action-core]: Use FQCN for builtin module actions (file). (warning) # ignored ansible/tasks/internal/setup-nftables.yml:2:3 Use `ansible.builtin.file` or `ansible.legacy.file` instead. name[casing]: All names should start with an uppercase letter. (warning) # ignored ansible/tasks/internal/setup-nftables.yml:7:9 Task/Handler: nftables empty config risky-file-permissions: File permissions unset or incorrect. (warning) # ignored ansible/tasks/internal/setup-nftables.yml:7 Task/Handler: nftables empty config fqcn[action-core]: Use FQCN for builtin module actions (file). (warning) # ignored ansible/tasks/internal/setup-nftables.yml:8:3 Use `ansible.builtin.file` or `ansible.legacy.file` instead. name[casing]: All names should start with an uppercase letter. (warning) # ignored ansible/tasks/internal/setup-nftables.yml:13:9 Task/Handler: include managed config no-changed-when: Commands should not change things if nothing needs doing. (warning) # ignored ansible/tasks/internal/setup-nftables.yml:13 Task/Handler: include managed config fqcn[action-core]: Use FQCN for builtin module actions (shell). (warning) # ignored ansible/tasks/internal/setup-nftables.yml:14:3 Use `ansible.builtin.shell` or `ansible.legacy.shell` instead. name[casing]: All names should start with an uppercase letter. (warning) # ignored ansible/tasks/internal/setup-nftables.yml:21:9 Task/Handler: install per-user egress filters fqcn[action-core]: Use FQCN for builtin module actions (copy). (warning) # ignored ansible/tasks/internal/setup-nftables.yml:22:3 Use `ansible.builtin.copy` or `ansible.legacy.copy` instead. name[casing]: All names should start with an uppercase letter. (warning) # ignored ansible/tasks/internal/setup-nftables.yml:29:9 Task/Handler: include per-user egress filters fqcn[action-core]: Use FQCN for builtin module actions (blockinfile). (warning) # ignored ansible/tasks/internal/setup-nftables.yml:30:3 Use `ansible.builtin.blockinfile` or `ansible.legacy.blockinfile` instead. name[casing]: All names should start with an uppercase letter. (warning) # ignored ansible/tasks/internal/setup-nftables.yml:38:9 Task/Handler: check the full nftables config parses fqcn[action-core]: Use FQCN for builtin module actions (command). (warning) # ignored ansible/tasks/internal/setup-nftables.yml:39:3 Use `ansible.builtin.command` or `ansible.legacy.command` instead. name[casing]: All names should start with an uppercase letter. (warning) # ignored ansible/tasks/internal/setup-nftables.yml:42:9 Task/Handler: ufw overrides dir risky-file-permissions: File permissions unset or incorrect. (warning) # ignored ansible/tasks/internal/setup-nftables.yml:42 Task/Handler: ufw overrides dir fqcn[action-core]: Use FQCN for builtin module actions (file). (warning) # ignored ansible/tasks/internal/setup-nftables.yml:43:3 Use `ansible.builtin.file` or `ansible.legacy.file` instead. risky-file-permissions: File permissions unset or incorrect. (warning) # ignored ansible/tasks/internal/setup-nftables.yml:48 Task/Handler: Custom systemd overrides fqcn[action-core]: Use FQCN for builtin module actions (copy). (warning) # ignored ansible/tasks/internal/setup-nftables.yml:49:3 Use `ansible.builtin.copy` or `ansible.legacy.copy` instead. name[casing]: All names should start with an uppercase letter. (warning) # ignored ansible/tasks/internal/setup-nftables.yml:53:9 Task/Handler: reload systemd fqcn[action-core]: Use FQCN for builtin module actions (systemd). (warning) # ignored ansible/tasks/internal/setup-nftables.yml:54:3 Use `ansible.builtin.systemd` or `ansible.legacy.systemd` instead. name[casing]: All names should start with an uppercase letter. (warning) # ignored ansible/tasks/internal/supabase-admin-agent.yml:1:9 Task/Handler: supabase-admin-agent - system group name[casing]: All names should start with an uppercase letter. (warning) # ignored ansible/tasks/internal/supabase-admin-agent.yml:7:9 Task/Handler: supabase-admin-agent - system user name[casing]: All names should start with an uppercase letter. (warning) # ignored ansible/tasks/internal/supabase-admin-agent.yml:17:9 Task/Handler: supabase-admin-agent - config dir risky-file-permissions: File permissions unset or incorrect. (warning) # ignored ansible/tasks/internal/supabase-admin-agent.yml:17 Task/Handler: supabase-admin-agent - config dir fqcn[action-core]: Use FQCN for builtin module actions (file). (warning) # ignored ansible/tasks/internal/supabase-admin-agent.yml:18:3 Use `ansible.builtin.file` or `ansible.legacy.file` instead. name[casing]: All names should start with an uppercase letter. (warning) # ignored ansible/tasks/internal/supabase-admin-agent.yml:23:9 Task/Handler: supabase-admin-agent - gpg dir risky-file-permissions: File permissions unset or incorrect. (warning) # ignored ansible/tasks/internal/supabase-admin-agent.yml:23 Task/Handler: supabase-admin-agent - gpg dir fqcn[action-core]: Use FQCN for builtin module actions (file). (warning) # ignored ansible/tasks/internal/supabase-admin-agent.yml:24:3 Use `ansible.builtin.file` or `ansible.legacy.file` instead. name[casing]: All names should start with an uppercase letter. (warning) # ignored ansible/tasks/internal/supabase-admin-agent.yml:30:9 Task/Handler: give supabase-admin-agent user permissions fqcn[action-core]: Use FQCN for builtin module actions (copy). (warning) # ignored ansible/tasks/internal/supabase-admin-agent.yml:31:3 Use `ansible.builtin.copy` or `ansible.legacy.copy` instead. name[casing]: All names should start with an uppercase letter. (warning) # ignored ansible/tasks/internal/supabase-admin-agent.yml:36:9 Task/Handler: supabase-admin-agent - pgbackrest helper scripts dir fqcn[action-core]: Use FQCN for builtin module actions (file). (warning) # ignored ansible/tasks/internal/supabase-admin-agent.yml:37:3 Use `ansible.builtin.file` or `ansible.legacy.file` instead. name[casing]: All names should start with an uppercase letter. (warning) # ignored ansible/tasks/internal/supabase-admin-agent.yml:44:9 Task/Handler: supabase-admin-agent - pgdata-chown script fqcn[action-core]: Use FQCN for builtin module actions (copy). (warning) # ignored ansible/tasks/internal/supabase-admin-agent.yml:45:3 Use `ansible.builtin.copy` or `ansible.legacy.copy` instead. name[casing]: All names should start with an uppercase letter. (warning) # ignored ansible/tasks/internal/supabase-admin-agent.yml:53:9 Task/Handler: supabase-admin-agent - pgdata-signal script fqcn[action-core]: Use FQCN for builtin module actions (copy). (warning) # ignored ansible/tasks/internal/supabase-admin-agent.yml:54:3 Use `ansible.builtin.copy` or `ansible.legacy.copy` instead. risky-file-permissions: File permissions unset or incorrect. (warning) # ignored ansible/tasks/internal/supabase-admin-agent.yml:63 Task/Handler: Download supabase-admin-agent archive fqcn[action-core]: Use FQCN for builtin module actions (get_url). (warning) # ignored ansible/tasks/internal/supabase-admin-agent.yml:64:3 Use `ansible.builtin.get_url` or `ansible.legacy.get_url` instead. name[casing]: All names should start with an uppercase letter. (warning) # ignored ansible/tasks/internal/supabase-admin-agent.yml:74:9 Task/Handler: supabase-admin-agent - unpack archive in /opt fqcn[action-core]: Use FQCN for builtin module actions (unarchive). (warning) # ignored ansible/tasks/internal/supabase-admin-agent.yml:75:3 Use `ansible.builtin.unarchive` or `ansible.legacy.unarchive` instead. name[casing]: All names should start with an uppercase letter. (warning) # ignored ansible/tasks/internal/supabase-admin-agent.yml:83:9 Task/Handler: supabase-admin-agent - create symlink name[casing]: All names should start with an uppercase letter. (warning) # ignored ansible/tasks/internal/supabase-admin-agent.yml:92:9 Task/Handler: supabase-admin-agent - create salt systemd timer file risky-file-permissions: File permissions unset or incorrect. (warning) # ignored ansible/tasks/internal/supabase-admin-agent.yml:92 Task/Handler: supabase-admin-agent - create salt systemd timer file fqcn[action-core]: Use FQCN for builtin module actions (template). (warning) # ignored ansible/tasks/internal/supabase-admin-agent.yml:93:3 Use `ansible.builtin.template` or `ansible.legacy.template` instead. name[casing]: All names should start with an uppercase letter. (warning) # ignored ansible/tasks/internal/supabase-admin-agent.yml:97:9 Task/Handler: supabase-admin-agent - create salt service file risky-file-permissions: File permissions unset or incorrect. (warning) # ignored ansible/tasks/internal/supabase-admin-agent.yml:97 Task/Handler: supabase-admin-agent - create salt service file fqcn[action-core]: Use FQCN for builtin module actions (template). (warning) # ignored ansible/tasks/internal/supabase-admin-agent.yml:98:3 Use `ansible.builtin.template` or `ansible.legacy.template` instead. name[casing]: All names should start with an uppercase letter. (warning) # ignored ansible/tasks/internal/supabase-admin-agent.yml:102:9 Task/Handler: supabase-admin-agent - reload systemd fqcn[action-core]: Use FQCN for builtin module actions (systemd). (warning) # ignored ansible/tasks/internal/supabase-admin-agent.yml:103:3 Use `ansible.builtin.systemd` or `ansible.legacy.systemd` instead. name[casing]: All names should start with an uppercase letter. (warning) # ignored ansible/tasks/internal/supabase-admin-agent.yml:107:9 Task/Handler: supabase-admin-agent - DISABLE service fqcn[action-core]: Use FQCN for builtin module actions (systemd). (warning) # ignored ansible/tasks/internal/supabase-admin-agent.yml:108:3 Use `ansible.builtin.systemd` or `ansible.legacy.systemd` instead. name[casing]: All names should start with an uppercase letter. (warning) # ignored ansible/tasks/setup-fail2ban.yml:2:9 Task/Handler: do stage1 tasks name[casing]: All names should start with an uppercase letter. (warning) # ignored ansible/tasks/setup-fail2ban.yml:5:13 Task/Handler: extend the default bantime to an hour name[casing]: All names should start with an uppercase letter. (warning) # ignored ansible/tasks/setup-fail2ban.yml:12:13 Task/Handler: configure journald risky-file-permissions: File permissions unset or incorrect. (warning) # ignored ansible/tasks/setup-fail2ban.yml:12 Task/Handler: configure journald name[casing]: All names should start with an uppercase letter. (warning) # ignored ansible/tasks/setup-fail2ban.yml:17:13 Task/Handler: configure fail2ban to use nftables risky-file-permissions: File permissions unset or incorrect. (warning) # ignored ansible/tasks/setup-fail2ban.yml:17 Task/Handler: configure fail2ban to use nftables name[casing]: All names should start with an uppercase letter. (warning) # ignored ansible/tasks/setup-fail2ban.yml:23:13 Task/Handler: import jail.d/postgresql.conf risky-file-permissions: File permissions unset or incorrect. (warning) # ignored ansible/tasks/setup-fail2ban.yml:23 Task/Handler: import jail.d/postgresql.conf name[casing]: All names should start with an uppercase letter. (warning) # ignored ansible/tasks/setup-fail2ban.yml:29:13 Task/Handler: import filter.d/postgresql.conf risky-file-permissions: File permissions unset or incorrect. (warning) # ignored ansible/tasks/setup-fail2ban.yml:29 Task/Handler: import filter.d/postgresql.conf name[casing]: All names should start with an uppercase letter. (warning) # ignored ansible/tasks/setup-fail2ban.yml:35:13 Task/Handler: create overrides dir name[casing]: All names should start with an uppercase letter. (warning) # ignored ansible/tasks/setup-fail2ban.yml:43:13 Task/Handler: custom systemd overrides risky-file-permissions: File permissions unset or incorrect. (warning) # ignored ansible/tasks/setup-fail2ban.yml:43 Task/Handler: custom systemd overrides name[casing]: All names should start with an uppercase letter. (warning) # ignored ansible/tasks/setup-fail2ban.yml:48:13 Task/Handler: add in supabase specific ignore filters name[casing]: All names should start with an uppercase letter. (warning) # ignored ansible/tasks/setup-fail2ban.yml:65:13 Task/Handler: fail2ban - disable service name[casing]: All names should start with an uppercase letter. (warning) # ignored ansible/tasks/setup-gotrue.yml:20:9 Task/Handler: gotrue - download commit archive risky-file-permissions: File permissions unset or incorrect. (warning) # ignored ansible/tasks/setup-gotrue.yml:20 Task/Handler: gotrue - download commit archive name[casing]: All names should start with an uppercase letter. (warning) # ignored ansible/tasks/setup-gotrue.yml:30:9 Task/Handler: gotrue - create /opt/gotrue and /etc/auth.d name[casing]: All names should start with an uppercase letter. (warning) # ignored ansible/tasks/setup-gotrue.yml:42:9 Task/Handler: gotrue - unpack archive in /opt/gotrue name[casing]: All names should start with an uppercase letter. (warning) # ignored ansible/tasks/setup-gotrue.yml:56:9 Task/Handler: gotrue - create service file risky-file-permissions: File permissions unset or incorrect. (warning) # ignored ansible/tasks/setup-gotrue.yml:56 Task/Handler: gotrue - create service file name[casing]: All names should start with an uppercase letter. (warning) # ignored ansible/tasks/setup-gotrue.yml:61:9 Task/Handler: gotrue - create optimizations file risky-file-permissions: File permissions unset or incorrect. (warning) # ignored ansible/tasks/setup-gotrue.yml:61 Task/Handler: gotrue - create optimizations file name[casing]: All names should start with an uppercase letter. (warning) # ignored ansible/tasks/setup-gotrue.yml:66:9 Task/Handler: gotrue - reload systemd risky-file-permissions: File permissions unset or incorrect. (warning) # ignored ansible/tasks/setup-kong.yml:23 Task/Handler: Kong - download deb package fqcn[action-core]: Use FQCN for builtin module actions (get_url). (warning) # ignored ansible/tasks/setup-kong.yml:24:3 Use `ansible.builtin.get_url` or `ansible.legacy.get_url` instead. no-changed-when: Commands should not change things if nothing needs doing. (warning) # ignored ansible/tasks/setup-kong.yml:37 Task/Handler: Kong - ensure it is NOT autoremoved risky-file-permissions: File permissions unset or incorrect. (warning) # ignored ansible/tasks/setup-kong.yml:41 Task/Handler: Kong - configuration risky-file-permissions: File permissions unset or incorrect. (warning) # ignored ansible/tasks/setup-kong.yml:61 Task/Handler: Kong - create env file risky-file-permissions: File permissions unset or incorrect. (warning) # ignored ansible/tasks/setup-kong.yml:66 Task/Handler: Kong - create service file name[casing]: All names should start with an uppercase letter. (warning) # ignored ansible/tasks/setup-kvm-timesync.yml:3:9 Task/Handler: phc2sys - install name[casing]: All names should start with an uppercase letter. (warning) # ignored ansible/tasks/setup-kvm-timesync.yml:8:9 Task/Handler: phc2sys - create service file risky-file-permissions: File permissions unset or incorrect. (warning) # ignored ansible/tasks/setup-kvm-timesync.yml:8 Task/Handler: phc2sys - create service file name[casing]: All names should start with an uppercase letter. (warning) # ignored ansible/tasks/setup-kvm-timesync.yml:13:9 Task/Handler: phc2sys - enable service name[casing]: All names should start with an uppercase letter. (warning) # ignored ansible/tasks/setup-kvm-timesync.yml:20:9 Task/Handler: phc2sys - remove systemd-timesyncd name[casing]: All names should start with an uppercase letter. (warning) # ignored ansible/tasks/setup-kvm-timesync.yml:29:9 Task/Handler: ptp_kvm.ko - enable risky-file-permissions: File permissions unset or incorrect. (warning) # ignored ansible/tasks/setup-kvm-timesync.yml:29 Task/Handler: ptp_kvm.ko - enable name[casing]: All names should start with an uppercase letter. (warning) # ignored ansible/tasks/setup-migrations.yml:1:9 Task/Handler: run stage2 tasks no-changed-when: Commands should not change things if nothing needs doing. (warning) # ignored ansible/tasks/setup-migrations.yml:4 Task/Handler: Run migrate.sh script risky-file-permissions: File permissions unset or incorrect. (warning) # ignored ansible/tasks/setup-migrations.yml:13 Task/Handler: Create /root/MIGRATION-AMI file no-changed-when: Commands should not change things if nothing needs doing. (warning) # ignored ansible/tasks/setup-pgbouncer.yml:18 Task/Handler: Install PgBouncer from nix binary cache name[casing]: All names should start with an uppercase letter. (warning) # ignored ansible/tasks/setup-pgbouncer.yml:47:9 Task/Handler: create PgBouncer placeholder config files name[casing]: All names should start with an uppercase letter. (warning) # ignored ansible/tasks/setup-pgbouncer.yml:76:9 Task/Handler: import /etc/tmpfiles.d/pgbouncer.conf risky-file-permissions: File permissions unset or incorrect. (warning) # ignored ansible/tasks/setup-pgbouncer.yml:76 Task/Handler: import /etc/tmpfiles.d/pgbouncer.conf name[casing]: All names should start with an uppercase letter. (warning) # ignored ansible/tasks/setup-pgbouncer.yml:99:9 Task/Handler: import jail.d/pgbouncer.conf risky-file-permissions: File permissions unset or incorrect. (warning) # ignored ansible/tasks/setup-pgbouncer.yml:99 Task/Handler: import jail.d/pgbouncer.conf name[casing]: All names should start with an uppercase letter. (warning) # ignored ansible/tasks/setup-pgbouncer.yml:105:9 Task/Handler: import filter.d/pgbouncer.conf risky-file-permissions: File permissions unset or incorrect. (warning) # ignored ansible/tasks/setup-pgbouncer.yml:105 Task/Handler: import filter.d/pgbouncer.conf risky-file-permissions: File permissions unset or incorrect. (warning) # ignored ansible/tasks/setup-pgbouncer.yml:112 Task/Handler: PgBouncer - import pgbouncer.service name[casing]: All names should start with an uppercase letter. (warning) # ignored ansible/tasks/setup-postgres.yml:1:9 Task/Handler: execute stage1 tasks name[casing]: All names should start with an uppercase letter. (warning) # ignored ansible/tasks/setup-postgres.yml:6:13 Task/Handler: create ssl-cert group name[casing]: All names should start with an uppercase letter. (warning) # ignored ansible/tasks/setup-postgres.yml:12:13 Task/Handler: create postgres group name[casing]: All names should start with an uppercase letter. (warning) # ignored ansible/tasks/setup-postgres.yml:18:13 Task/Handler: create postgres user name[casing]: All names should start with an uppercase letter. (warning) # ignored ansible/tasks/setup-postgres.yml:71:13 Task/Handler: create placeholder config files name[casing]: All names should start with an uppercase letter. (warning) # ignored ansible/tasks/setup-postgres.yml:84:13 Task/Handler: import postgresql.conf, pg_hba.conf, and pg_ident.conf risky-file-permissions: File permissions unset or incorrect. (warning) # ignored ansible/tasks/setup-postgres.yml:84 Task/Handler: import postgresql.conf, pg_hba.conf, and pg_ident.conf risky-file-permissions: File permissions unset or incorrect. (warning) # ignored ansible/tasks/setup-postgres.yml:134 Task/Handler: Make sure .bashrc exists name[casing]: All names should start with an uppercase letter. (warning) # ignored ansible/tasks/setup-postgres.yml:141:9 Task/Handler: execute stage2 tasks name[casing]: All names should start with an uppercase letter. (warning) # ignored ansible/tasks/setup-postgres.yml:144:13 Task/Handler: install locales name[casing]: All names should start with an uppercase letter. (warning) # ignored ansible/tasks/setup-postgres.yml:149:13 Task/Handler: configure locales risky-file-permissions: File permissions unset or incorrect. (warning) # ignored ansible/tasks/setup-postgres.yml:149 Task/Handler: configure locales name[casing]: All names should start with an uppercase letter. (warning) # ignored ansible/tasks/setup-postgres.yml:161:13 Task/Handler: locale-gen no-changed-when: Commands should not change things if nothing needs doing. (warning) # ignored ansible/tasks/setup-postgres.yml:161 Task/Handler: locale-gen name[casing]: All names should start with an uppercase letter. (warning) # ignored ansible/tasks/setup-postgres.yml:165:13 Task/Handler: update-locale no-changed-when: Commands should not change things if nothing needs doing. (warning) # ignored ansible/tasks/setup-postgres.yml:165 Task/Handler: update-locale name[casing]: All names should start with an uppercase letter. (warning) # ignored ansible/tasks/setup-postgres.yml:173:13 Task/Handler: stage2 postgres tasks no-changed-when: Commands should not change things if nothing needs doing. (warning) # ignored ansible/tasks/setup-postgres.yml:188 Task/Handler: Initialize the database stage2 (PG15) no-changed-when: Commands should not change things if nothing needs doing. (warning) # ignored ansible/tasks/setup-postgres.yml:203 Task/Handler: Initialize the database stage2 (PG17+) name[casing]: All names should start with an uppercase letter. (warning) # ignored ansible/tasks/setup-postgres.yml:218:9 Task/Handler: copy PG apparmor profile name[casing]: All names should start with an uppercase letter. (warning) # ignored ansible/tasks/setup-postgres.yml:226:9 Task/Handler: ensure apparmor-utils are installed name[casing]: All names should start with an uppercase letter. (warning) # ignored ansible/tasks/setup-postgres.yml:230:9 Task/Handler: parse apparmor sbpostgres profile no-changed-when: Commands should not change things if nothing needs doing. (warning) # ignored ansible/tasks/setup-postgres.yml:230 Task/Handler: parse apparmor sbpostgres profile name[casing]: All names should start with an uppercase letter. (warning) # ignored ansible/tasks/setup-postgres.yml:234:9 Task/Handler: reload apparmor with sbpostgres profile no-changed-when: Commands should not change things if nothing needs doing. (warning) # ignored ansible/tasks/setup-postgres.yml:234 Task/Handler: reload apparmor with sbpostgres profile name[casing]: All names should start with an uppercase letter. (warning) # ignored ansible/tasks/setup-postgres.yml:238:9 Task/Handler: copy PG and optimizations systemd units risky-file-permissions: File permissions unset or incorrect. (warning) # ignored ansible/tasks/setup-postgres.yml:238 Task/Handler: copy PG and optimizations systemd units name[casing]: All names should start with an uppercase letter. (warning) # ignored ansible/tasks/setup-postgres.yml:249:9 Task/Handler: initialize pg required state risky-file-permissions: File permissions unset or incorrect. (warning) # ignored ansible/tasks/setup-postgres.yml:249 Task/Handler: initialize pg required state no-changed-when: Commands should not change things if nothing needs doing. (warning) # ignored ansible/tasks/setup-postgres.yml:259 Task/Handler: Restart Postgres Database without Systemd risky-file-permissions: File permissions unset or incorrect. (warning) # ignored ansible/tasks/setup-postgres.yml:314 Task/Handler: Add lang and locale items to .bashrc jinja[spacing]: Jinja2 spacing could be improved: {{postgrest_artifacts['signingkey']['url']}} -> {{ postgrest_artifacts['signingkey']['url'] }} (warning) # ignored ansible/tasks/setup-postgrest.yml:16:10 Jinja2 template rewrite recommendation: `{{ postgrest_artifacts['signingkey']['url'] }}`. jinja[spacing]: Jinja2 spacing could be improved: {{postgrest_artifacts['signingkey']['checksum']}} -> {{ postgrest_artifacts['signingkey']['checksum'] }} (warning) # ignored ansible/tasks/setup-postgrest.yml:17:15 Jinja2 template rewrite recommendation: `{{ postgrest_artifacts['signingkey']['checksum'] }}`. name[casing]: All names should start with an uppercase letter. (warning) # ignored ansible/tasks/setup-postgrest.yml:57:9 Task/Handler: postgis - ensure dependencies do not get autoremoved no-changed-when: Commands should not change things if nothing needs doing. (warning) # ignored ansible/tasks/setup-postgrest.yml:57 Task/Handler: postgis - ensure dependencies do not get autoremoved name[casing]: All names should start with an uppercase letter. (warning) # ignored ansible/tasks/setup-postgrest.yml:61:9 Task/Handler: postgis - allow libnuma-dev to be autoremoved no-changed-when: Commands should not change things if nothing needs doing. (warning) # ignored ansible/tasks/setup-postgrest.yml:61 Task/Handler: postgis - allow libnuma-dev to be autoremoved risky-file-permissions: File permissions unset or incorrect. (warning) # ignored ansible/tasks/setup-postgrest.yml:65 Task/Handler: PostgREST - download ubuntu binary archive (arm) name[casing]: All names should start with an uppercase letter. (warning) # ignored ansible/tasks/setup-postgrest.yml:84:9 Task/Handler: create directories name[casing]: All names should start with an uppercase letter. (warning) # ignored ansible/tasks/setup-postgrest.yml:92:9 Task/Handler: empty files risky-file-permissions: File permissions unset or incorrect. (warning) # ignored ansible/tasks/setup-postgrest.yml:92 Task/Handler: empty files name[casing]: All names should start with an uppercase letter. (warning) # ignored ansible/tasks/setup-postgrest.yml:104:9 Task/Handler: create conf merging script risky-file-permissions: File permissions unset or incorrect. (warning) # ignored ansible/tasks/setup-postgrest.yml:117 Task/Handler: PostgREST - create service files name[casing]: All names should start with an uppercase letter. (warning) # ignored ansible/tasks/setup-supabase-internal.yml:5:9 Task/Handler: download Vector package risky-file-permissions: File permissions unset or incorrect. (warning) # ignored ansible/tasks/setup-supabase-internal.yml:5 Task/Handler: download Vector package name[casing]: All names should start with an uppercase letter. (warning) # ignored ansible/tasks/setup-supabase-internal.yml:23:9 Task/Handler: add vector system group name[casing]: All names should start with an uppercase letter. (warning) # ignored ansible/tasks/setup-supabase-internal.yml:29:9 Task/Handler: add vector system user name[casing]: All names should start with an uppercase letter. (warning) # ignored ansible/tasks/setup-supabase-internal.yml:40:9 Task/Handler: install Vector for logging fqcn[action-core]: Use FQCN for builtin module actions (apt). (warning) # ignored ansible/tasks/setup-supabase-internal.yml:41:3 Use `ansible.builtin.apt` or `ansible.legacy.apt` instead. name[casing]: All names should start with an uppercase letter. (warning) # ignored ansible/tasks/setup-supabase-internal.yml:45:9 Task/Handler: create service files for Vector risky-file-permissions: File permissions unset or incorrect. (warning) # ignored ansible/tasks/setup-supabase-internal.yml:45 Task/Handler: create service files for Vector name[casing]: All names should start with an uppercase letter. (warning) # ignored ansible/tasks/setup-supabase-internal.yml:50:9 Task/Handler: configure tmpfiles for postgres - overwrites upstream package risky-file-permissions: File permissions unset or incorrect. (warning) # ignored ansible/tasks/setup-supabase-internal.yml:50 Task/Handler: configure tmpfiles for postgres - overwrites upstream package name[casing]: All names should start with an uppercase letter. (warning) # ignored ansible/tasks/setup-supabase-internal.yml:55:9 Task/Handler: fix permissions for vector config to be managed name[casing]: All names should start with an uppercase letter. (warning) # ignored ansible/tasks/setup-supabase-internal.yml:64:9 Task/Handler: vector - reload systemd risky-file-permissions: File permissions unset or incorrect. (warning) # ignored ansible/tasks/setup-supabase-internal.yml:68 Task/Handler: Create checkpoints dir no-changed-when: Commands should not change things if nothing needs doing. (warning) # ignored ansible/tasks/setup-supabase-internal.yml:129 Task/Handler: Envoy - use lds.supabase.yaml for /etc/envoy/lds.yaml name[casing]: All names should start with an uppercase letter. (warning) # ignored ansible/tasks/setup-supautils.yml:4:13 Task/Handler: supautils - add supautils to session_preload_libraries name[casing]: All names should start with an uppercase letter. (warning) # ignored ansible/tasks/setup-supautils.yml:11:13 Task/Handler: supautils - write custom supautils.conf name[casing]: All names should start with an uppercase letter. (warning) # ignored ansible/tasks/setup-supautils.yml:19:13 Task/Handler: supautils - copy extension custom scripts risky-file-permissions: File permissions unset or incorrect. (warning) # ignored ansible/tasks/setup-supautils.yml:19 Task/Handler: supautils - copy extension custom scripts name[casing]: All names should start with an uppercase letter. (warning) # ignored ansible/tasks/setup-supautils.yml:25:13 Task/Handler: supautils - chown extension custom scripts name[casing]: All names should start with an uppercase letter. (warning) # ignored ansible/tasks/setup-supautils.yml:34:13 Task/Handler: supautils - include /etc/postgresql-custom/supautils.conf in postgresql.conf name[casing]: All names should start with an uppercase letter. (warning) # ignored ansible/tasks/setup-system.yml:75:13 Task/Handler: restart ufw risky-file-permissions: File permissions unset or incorrect. (warning) # ignored ansible/tasks/setup-system.yml:80 Task/Handler: Create Sysstat log directory risky-file-permissions: File permissions unset or incorrect. (warning) # ignored ansible/tasks/setup-system.yml:85 Task/Handler: Configure sysstat risky-file-permissions: File permissions unset or incorrect. (warning) # ignored ansible/tasks/setup-system.yml:95 Task/Handler: Adjust APT update intervals risky-file-permissions: File permissions unset or incorrect. (warning) # ignored ansible/tasks/setup-system.yml:112 Task/Handler: Disable kexec handover risky-file-permissions: File permissions unset or incorrect. (warning) # ignored ansible/tasks/setup-system.yml:123 Task/Handler: Enable zswap risky-file-permissions: File permissions unset or incorrect. (warning) # ignored ansible/tasks/setup-system.yml:166 Task/Handler: System - Create services.slice risky-file-permissions: File permissions unset or incorrect. (warning) # ignored ansible/tasks/setup-system.yml:175 Task/Handler: Configure journald and logind name[casing]: All names should start with an uppercase letter. (warning) # ignored ansible/tasks/setup-system.yml:185:13 Task/Handler: reload systemd-journald name[casing]: All names should start with an uppercase letter. (warning) # ignored ansible/tasks/setup-system.yml:195:13 Task/Handler: enable timestamps for shell history name[casing]: All names should start with an uppercase letter. (warning) # ignored ansible/tasks/setup-system.yml:204:13 Task/Handler: configure systemd's pager name[casing]: All names should start with an uppercase letter. (warning) # ignored ansible/tasks/setup-system.yml:213:9 Task/Handler: set hosts file name[casing]: All names should start with an uppercase letter. (warning) # ignored ansible/tasks/setup-system.yml:224:9 Task/Handler: configure NTP client name[casing]: All names should start with an uppercase letter. (warning) # ignored ansible/tasks/setup-system.yml:227:13 Task/Handler: ensure conf directory exists name[casing]: All names should start with an uppercase letter. (warning) # ignored ansible/tasks/setup-system.yml:233:13 Task/Handler: configure NTP server name[casing]: All names should start with an uppercase letter. (warning) # ignored ansible/tasks/setup-tmux.yml:1:9 Task/Handler: tmux - Install tmux name[casing]: All names should start with an uppercase letter. (warning) # ignored ansible/tasks/setup-tmux.yml:7:9 Task/Handler: tmux - Configure tmux alias name[casing]: All names should start with an uppercase letter. (warning) # ignored ansible/tasks/setup-tmux.yml:19:9 Task/Handler: tmux - Configure tmux name[casing]: All names should start with an uppercase letter. (warning) # ignored ansible/tasks/setup-tmux.yml:28:9 Task/Handler: tmux - Auto-logout from stale tmux no-changed-when: Commands should not change things if nothing needs doing. (warning) # ignored ansible/tasks/setup-wal-g.yml:37 Task/Handler: Install wal-g 2 from nix binary cache no-changed-when: Commands should not change things if nothing needs doing. (warning) # ignored ansible/tasks/setup-wal-g.yml:45 Task/Handler: Install wal-g 3 from nix binary cache no-changed-when: Commands should not change things if nothing needs doing. (warning) # ignored ansible/tasks/stage2-setup-postgres.yml:65 Task/Handler: Install postgres env from nix binary cache no-changed-when: Commands should not change things if nothing needs doing. (warning) # ignored ansible/tasks/stage2-setup-postgres.yml:72 Task/Handler: Install and activate site env from nix binary cache yaml[commas]: Too many spaces before comma (warning) # ignored ansible/tasks/stage2-setup-postgres.yml:87 name[casing]: All names should start with an uppercase letter. (warning) # ignored ansible/tasks/stage2-setup-postgres.yml:97:13 Task/Handler: import pgsodium_getkey script name[casing]: All names should start with an uppercase letter. (warning) # ignored ansible/tasks/stage2-setup-postgres.yml:119:13 Task/Handler: setup gatekeeper no-changed-when: Commands should not change things if nothing needs doing. (warning) # ignored ansible/tasks/stage2-setup-postgres.yml:124 Task/Handler: Create symbolic link for linux-pam to find pam_jit_pg.so fqcn[action-core]: Use FQCN for builtin module actions (shell). (warning) # ignored ansible/tasks/stage2-setup-postgres.yml:126:15 Use `ansible.builtin.shell` or `ansible.legacy.shell` instead. no-changed-when: Commands should not change things if nothing needs doing. (warning) # ignored ansible/tasks/stage2-setup-postgres.yml:129 Task/Handler: Get gatekeeper version risky-shell-pipe: Shells that use pipes should set the pipefail option. (warning) # ignored ansible/tasks/stage2-setup-postgres.yml:129 Task/Handler: Get gatekeeper version risky-file-permissions: File permissions unset or incorrect. (warning) # ignored ansible/tasks/stage2-setup-postgres.yml:136 Task/Handler: Write version file name[casing]: All names should start with an uppercase letter. (warning) # ignored ansible/tasks/stage2-setup-postgres.yml:208:13 Task/Handler: create destination directory name[casing]: All names should start with an uppercase letter. (warning) # ignored ansible/tasks/stage2-setup-postgres.yml:215:13 Task/Handler: pgsodium - set pgsodium.getkey_script risky-file-permissions: File permissions unset or incorrect. (warning) # ignored ansible/tasks/test-image.yml:4 Task/Handler: Make a backup of the /etc/postgresql/postgresql.conf file no-changed-when: Commands should not change things if nothing needs doing. (warning) # ignored ansible/tasks/test-image.yml:41 Task/Handler: Restart Postgres Database in stage 2 to load all extensions no-changed-when: Commands should not change things if nothing needs doing. (warning) # ignored ansible/tasks/test-image.yml:58 Task/Handler: Re-enable PG Sodium references in /etc/postgresql/postgresql.conf no-changed-when: Commands should not change things if nothing needs doing. (warning) # ignored ansible/tasks/test-image.yml:82 Task/Handler: Restart Postgres Database in stage 2 to load all extensions Passed: 0 failure(s), 367 warning(s) on 172 files. Last profile that met the validation criteria was 'production'. shellcheck...............................................................Failed - hook id: shellcheck - exit code: 1 In ansible/files/admin_api_scripts/pg_upgrade_scripts/initiate.sh line 686: timeout -k "${KILL_AFTER}" "${MAX_DURATION}" ${PGBINOLD}/pg_checksums -e "${PGDATAOLD}" || STATUS=$? ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: timeout -k "${KILL_AFTER}" "${MAX_DURATION}" "${PGBINOLD}"/pg_checksums -e "${PGDATAOLD}" || STATUS=$? For more information: https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ... In ansible/files/admin_api_scripts/pg_upgrade_scripts/prepare.sh line 116: log "$(ls -l /proc/* 2>/dev/null | grep 'data' || true)" ^-- SC2010 (warning): Don't use ls | grep. Use a glob or a for loop with a condition to allow non-alphanumeric filenames. For more information: https://www.shellcheck.net/wiki/SC2010 -- Don't use ls | grep. Use a glob o... treefmt..................................................................Failed - hook id: treefmt - duration: 0.59s - exit code: 1 - files were modified by this hook ERRO file has changed path=ansible/files/admin_api_scripts/pg_upgrade_scripts/common.sh prev_size=25221 prev_mod_time="1970-01-01 00:00:01 +0000 UTC" current_size=25220 current_mod_time="2026-11-09 14:12:46 +0000 UTC" ERRO file has changed path=ansible/files/admin_api_scripts/pg_upgrade_scripts/initiate.sh prev_size=31034 prev_mod_time="1970-01-01 00:00:01 +0000 UTC" current_size=30859 current_mod_time="2026-11-09 14:12:46 +0000 UTC" ERRO file has changed path=ansible/files/admin_api_scripts/pg_upgrade_scripts/prepare.sh prev_size=4594 prev_mod_time="1970-01-01 00:00:01 +0000 UTC" current_size=4549 current_mod_time="2026-11-09 14:12:46 +0000 UTC" ERRO file has changed path=ansible/files/admin_api_scripts/pg_upgrade_scripts/start_guard.sh prev_size=8757 prev_mod_time="1970-01-01 00:00:01 +0000 UTC" current_size=8754 current_mod_time="2026-11-09 14:12:46 +0000 UTC" traversed 940 files emitted 234 files for processing formatted 234 files (4 changed) in 578ms Error: unexpected changes detected, --fail-on-change is enabled versioning-scheme........................................................Passed - hook id: versioning-scheme - duration: 0.01s diff --git a/ansible/files/admin_api_scripts/pg_upgrade_scripts/common.sh b/ansible/files/admin_api_scripts/pg_upgrade_scripts/common.sh index 671c392..1cbe9f2 100755 --- a/ansible/files/admin_api_scripts/pg_upgrade_scripts/common.sh +++ b/ansible/files/admin_api_scripts/pg_upgrade_scripts/common.sh @@ -1,6 +1,6 @@ #! /usr/bin/env bash -# Common functions and variables used by +# Common functions and variables used by # prepare.sh, initiate.sh and complete.sh #staging/prod diff --git a/ansible/files/admin_api_scripts/pg_upgrade_scripts/initiate.sh b/ansible/files/admin_api_scripts/pg_upgrade_scripts/initiate.sh index e31a74a..ecea3de 100755 --- a/ansible/files/admin_api_scripts/pg_upgrade_scripts/initiate.sh +++ b/ansible/files/admin_api_scripts/pg_upgrade_scripts/initiate.sh @@ -133,11 +133,11 @@ cleanup() { # can fail under set -e, or the restart below would be refused. unblock_postgres_start || log "WARNING: failed to lift the postgres start block; check /run/systemd/system/postgresql.service.d" - # jparem : $LOG_FILE exists, even if directory - # ${MOUNT_POINT}/pgdata/pg_upgrade_output.d/ does not! - # so removing the ship-ing of the log here rather than the conditional block - # down there.. - # https://linear.app/supabase/issue/MPG-1531/initiatesh-call-ship-logs-no-matter-what + # jparem : $LOG_FILE exists, even if directory + # ${MOUNT_POINT}/pgdata/pg_upgrade_output.d/ does not! + # so removing the ship-ing of the log here rather than the conditional block + # down there.. + # https://linear.app/supabase/issue/MPG-1531/initiatesh-call-ship-logs-no-matter-what ship_logs "$LOG_FILE" || true if [ -d "${MOUNT_POINT}/pgdata/pg_upgrade_output.d/" ]; then @@ -657,71 +657,71 @@ EOF CI_stop_postgres fi - #CHECKSUM_FLAG="--data-checksums" if the SOURCE cluster has checksums - #CHECKSUM_FLAG="" if the SOURCE doesn't have them (yet) - # in this case the following code adds them + #CHECKSUM_FLAG="--data-checksums" if the SOURCE cluster has checksums + #CHECKSUM_FLAG="" if the SOURCE doesn't have them (yet) + # in this case the following code adds them - if [[ "$CHECKSUM_FLAG" == "" ]]; then + if [[ $CHECKSUM_FLAG == "" ]]; then - # old db hasn't got checksum, we will enable it its overall size - # (${PGDATAOLD}) is <= 20 Gb + # old db hasn't got checksum, we will enable it its overall size + # (${PGDATAOLD}) is <= 20 Gb - # 20 gb = 20 x 1024 x 1024 = 20971520 - MAX_SIZE=20971520 - - PGDATAOLD_SIZE=$(du -sk "${PGDATAOLD}" | cut -f1) + # 20 gb = 20 x 1024 x 1024 = 20971520 + MAX_SIZE=20971520 - if [[ "$PGDATAOLD_SIZE" -le "$MAX_SIZE" ]]; then + PGDATAOLD_SIZE=$(du -sk "${PGDATAOLD}" | cut -f1) - log "9.1 adding checksums to SOURCE PG (<20 Gb)" + if [[ $PGDATAOLD_SIZE -le $MAX_SIZE ]]; then - # we're adding a timer: the "pg_checksum -e" operation on ${PGDATAOLD} must - # not run for more than 10 minutes otherwise we exist this code on error - # ofc, if the pg_checksums detects a physical corruption, we have to exit - # the program with a consistent message explaining the corruption - - MAX_DURATION="10m" - KILL_AFTER="15s" + log "9.1 adding checksums to SOURCE PG (<20 Gb)" - timeout -k "${KILL_AFTER}" "${MAX_DURATION}" ${PGBINOLD}/pg_checksums -e "${PGDATAOLD}" || STATUS=$? + # we're adding a timer: the "pg_checksum -e" operation on ${PGDATAOLD} must + # not run for more than 10 minutes otherwise we exist this code on error + # ofc, if the pg_checksums detects a physical corruption, we have to exit + # the program with a consistent message explaining the corruption - # if everything is fine, $STATUS hasn't been defined, - # so we initialize it with 0 because it's a success - STATUS=${STATUS:-0} + MAX_DURATION="10m" + KILL_AFTER="15s" + + timeout -k "${KILL_AFTER}" "${MAX_DURATION}" ${PGBINOLD}/pg_checksums -e "${PGDATAOLD}" || STATUS=$? + + # if everything is fine, $STATUS hasn't been defined, + # so we initialize it with 0 because it's a success + STATUS=${STATUS:-0} # we'll manage ERROR codes down there, to actually log anything # properly, for later diagnostic reading the $LOG_FILE into project # where it has been shipped ship_logs() in common.sh - case $STATUS in - 0) - log "adding checksums SUCCEEDED." - ;; - 124|137) - log "adding checksums FAILED. Max time (${MAX_DURATION}) reached! Process killed." - exit 124 - ;; - *) - log "adding checksum FAILED with Error code ${STATUS}" - exit "$STATUS" - ;; - esac - - # we're here if everything went well with STATUS=0 - # so now, checksums are enabled on the SOURCE! - CHECKSUM_FLAG="--data-checksums" - - else - - log "9.1 did *not* add checksum to SOURCE PG: size $PGDATAOLD_SIZE > 20 Gb!" - - fi - - else - - log "9.1 checksums already present on SOURCE" - - fi + case $STATUS in + 0) + log "adding checksums SUCCEEDED." + ;; + 124 | 137) + log "adding checksums FAILED. Max time (${MAX_DURATION}) reached! Process killed." + exit 124 + ;; + *) + log "adding checksum FAILED with Error code ${STATUS}" + exit "$STATUS" + ;; + esac + + # we're here if everything went well with STATUS=0 + # so now, checksums are enabled on the SOURCE! + CHECKSUM_FLAG="--data-checksums" + + else + + log "9.1 did *not* add checksum to SOURCE PG: size $PGDATAOLD_SIZE > 20 Gb!" + + fi + + else + + log "9.1 checksums already present on SOURCE" + + fi log "10. Creating new data directory, initializing database" chown -R postgres:postgres "$MOUNT_POINT/" diff --git a/ansible/files/admin_api_scripts/pg_upgrade_scripts/prepare.sh b/ansible/files/admin_api_scripts/pg_upgrade_scripts/prepare.sh index a34f530..3f95e7e 100755 --- a/ansible/files/admin_api_scripts/pg_upgrade_scripts/prepare.sh +++ b/ansible/files/admin_api_scripts/pg_upgrade_scripts/prepare.sh @@ -22,7 +22,7 @@ chmod 640 "$LOG_FILE" # file, a previous attempt has run and failed. RETRY=0 if grep -qF "prepare.sh started" "$LOG_FILE"; then - RETRY=1 + RETRY=1 fi # From here on, everything written to stdout/stderr (log messages, but also @@ -40,8 +40,8 @@ trap 'log "prepare.sh FAILED at line $LINENO: \"$BASH_COMMAND\" (exit code $?)"' # Source the shared helpers (log and ship_logs functions) # shellcheck disable=SC1091 source "$SCRIPT_DIR/common.sh" || { - log "cannot source $SCRIPT_DIR/common.sh" - exit 1 + log "cannot source $SCRIPT_DIR/common.sh" + exit 1 } # ship_logs reads these variables, and "set -u" would abort the script on an @@ -57,23 +57,23 @@ source "$SCRIPT_DIR/common.sh" || { # retry, so the caller handles the "gave up" case. # The script's exit code is always preserved for the caller. on_exit() { - local rc=$? - trap - EXIT ERR # avoid re-entering the traps from inside this handler - - if [ "$rc" -eq 0 ]; then - if [ "$RETRY" -eq 0 ]; then - log "prepare.sh ended with no errors." - else - log "prepare.sh finally ended without error this time." - fi - # Single upload of the log file; never fatal - if declare -F ship_logs >/dev/null; then - ship_logs "$LOG_FILE" || log "Log upload failed (non-blocking)." - else - log "ship_logs is not available, log upload skipped." - fi - fi - exit "$rc" + local rc=$? + trap - EXIT ERR # avoid re-entering the traps from inside this handler + + if [ "$rc" -eq 0 ]; then + if [ "$RETRY" -eq 0 ]; then + log "prepare.sh ended with no errors." + else + log "prepare.sh finally ended without error this time." + fi + # Single upload of the log file; never fatal + if declare -F ship_logs >/dev/null; then + ship_logs "$LOG_FILE" || log "Log upload failed (non-blocking)." + else + log "ship_logs is not available, log upload skipped." + fi + fi + exit "$rc" } trap on_exit EXIT @@ -82,7 +82,10 @@ trap on_exit EXIT log "prepare.sh started." # check that /data is actually mounted -mountpoint -q /data || { log "/data is not mounted"; exit 1; } +mountpoint -q /data || { + log "/data is not mounted" + exit 1 +} # stop postgresql: "systemctl stop blocks until the unit has fully stopped" # https://linear.app/supabase/issue/MPG-1283/harden-a-bit-preparesh#comment-cea7446f @@ -91,17 +94,19 @@ systemctl stop postgresql # ...but let's still verify that the service is explicitly stopped if systemctl is-active --quiet postgresql; then - log "postgresql service is still active!"; exit 1 + log "postgresql service is still active!" + exit 1 fi # ...and that there are no remaining postgres processes if pgrep -x postgres >/dev/null; then - log "postgres processes are still alive!"; exit 1 + log "postgres processes are still alive!" + exit 1 fi # copy the pgsodium root key with proper owner and permissions install -m 600 -o postgres -g postgres \ - /etc/postgresql-custom/pgsodium_root.key /data/pgsodium_root.key + /etc/postgresql-custom/pgsodium_root.key /data/pgsodium_root.key # flush cached writes to persistent storage sync @@ -109,12 +114,12 @@ sync # Unmount /data. Capture the native umount error message and route it through # "log" so that it is timestamped like the rest of the log entries. if ! umount_out=$(umount /data 2>&1); then - log "Unable to unmount /data: $umount_out" - # List the processes still using /data ("|| true" so a fuser failure - # does not trigger the ERR trap and mask the real cause) - log "Processes using /data:" - log "$(ls -l /proc/* 2>/dev/null | grep 'data' || true)" - exit 1 + log "Unable to unmount /data: $umount_out" + # List the processes still using /data ("|| true" so a fuser failure + # does not trigger the ERR trap and mask the real cause) + log "Processes using /data:" + log "$(ls -l /proc/* 2>/dev/null | grep 'data' || true)" + exit 1 fi # Reaching this point means success: the final message and the log upload diff --git a/ansible/files/admin_api_scripts/pg_upgrade_scripts/start_guard.sh b/ansible/files/admin_api_scripts/pg_upgrade_scripts/start_guard.sh index c40fe69..1537a5c 100755 --- a/ansible/files/admin_api_scripts/pg_upgrade_scripts/start_guard.sh +++ b/ansible/files/admin_api_scripts/pg_upgrade_scripts/start_guard.sh @@ -4,9 +4,9 @@ # file copy. Sourced by initiate.sh and tests/pg_upgrade/test-start-guard.sh. # Expects log, IS_CI, PGDATAOLD and PGDATANEW from the caller. -# From step 9 until cleanup, nothing may start the source postgres: -# -# If it has to run, "pg_checksums -e" will operate on the source postgres, and +# From step 9 until cleanup, nothing may start the source postgres: +# +# If it has to run, "pg_checksums -e" will operate on the source postgres, and # this one has to stay stopped during the whole operation # # pg_upgrade copies the data files without a postmaster holding the directory,